fix(utils): make 'loadable' update immediate after resolve (#2790)

* fix(utils): make 'loadable' update immediate after resolve * fix comments in #2790 --------- Co-authored-by: Daishi Kato <[email protected]>
pmndrs · Nov 11, 2024 · c883763 · c883763
1 parent 6afbc09
commit c883763
Show file tree

Hide file tree

Showing 2 changed files with 23 additions and 10 deletions.
diff --git a/src/vanilla/utils/loadable.ts b/src/vanilla/utils/loadable.ts
@@ -44,16 +44,17 @@ export function loadable<Value>(anAtom: Atom<Value>): Atom<Loadable<Value>> {
         if (cached1) {
           return cached1
         }
-        promise
-          .then(
-            (data) => {
-              loadableCache.set(promise, { state: 'hasData', data })
-            },
-            (error) => {
-              loadableCache.set(promise, { state: 'hasError', error })
-            },
-          )
-          .finally(setSelf)
+        promise.then(
+          (data) => {
+            loadableCache.set(promise, { state: 'hasData', data })
+            setSelf()
+          },
+          (error) => {
+            loadableCache.set(promise, { state: 'hasError', error })
+            setSelf()
+          },
+        )
+
         const cached2 = loadableCache.get(promise)
         if (cached2) {
           return cached2

diff --git a/tests/vanilla/utils/loadable.test.ts b/tests/vanilla/utils/loadable.test.ts
@@ -17,4 +17,16 @@ describe('loadable', () => {
       data: 'concrete',
     })
   })
+
+  it('should get the latest loadable state after the promise resolves', async () => {
+    const store = createStore()
+    const asyncAtom = atom(Promise.resolve())
+    const loadableAtom = loadable(asyncAtom)
+
+    expect(store.get(loadableAtom)).toHaveProperty('state', 'loading')
+
+    await store.get(asyncAtom)
+
+    expect(store.get(loadableAtom)).toHaveProperty('state', 'hasData')
+  })
 })