Fix injectRefreshLoader performance issue #669
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigating some performance issues that only appear when enabling this plugin, I discovered that the
require.resolve('react-refresh')
which gets called ininjectRefreshLoader
seems to be the cause.Moving the call outside the
injectRefreshLoader
cuts initial compile time in more than half (~40s -> ~15s) and incremental compile time has a similar speedup (~8s -> ~3s).I don't know why, but I guess the require.resolve is not cached for some reason, or just takes some time, which adds up when the function runs for thousands of modules?
The change moving the
refreshUtilsPath
outside the function is not required to improve the performance, but I don't see why it wouldn't be moved outside the function as it should be static.Tested on two different machines running the same project. May or may not address this issue: #543