fix: fix getCurrentScriptSource to handle scripts without src #331
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
getCurrentScriptSource
will fail when there are scripts withoutsrc
used in the document and the script that runs React app is not the last script in the document.For example, in the case when there are other 3rd party script snippets such as Qualtrics used in the document, the last script get by the original implementation could be such script and the
src
will be null. As a result,getCurrentScriptSource
will returnnull
andgetSocketUrlParts
will fail aturl.parse(scriptSource || '')
.To fix this issue, we could return the last script that HAS
src
attribute as the current script.