feat: add sockProtocol option to overlay #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmmmwh
reviewed
Nov 2, 2020
pmmmwh
reviewed
Nov 7, 2020
pmmmwh
approved these changes
Nov 10, 2020
Co-authored-by: Michael Mok <[email protected]>
|
@pmmmwh Let me know if you need any help with the tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow forcing protocol for socket. This fixes error in non-standard environments like running the page with "data:" protocol. In that case it is impossible to know if the communication requires http or https.
All in all, having more configuration where it makes sense is always good and having a way to configure the protocol is one thing that seems to always be overlooked (eg. create-react-app)