Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only inject overlay in development mode and when window is defined #146

Merged
merged 1 commit into from
Jul 18, 2020
Merged

fix: only inject overlay in development mode and when window is defined #146

merged 1 commit into from
Jul 18, 2020

Conversation

pmmmwh
Copy link
Owner

@pmmmwh pmmmwh commented Jul 17, 2020

This is a work-around to make apps build for #143.

In the future, we might add an API to allow customizing the entry injection behaviour.

@pmmmwh pmmmwh added the enhancement New feature or request label Jul 17, 2020
@pmmmwh pmmmwh self-assigned this Jul 17, 2020
@pmmmwh pmmmwh merged commit 4b2331f into main Jul 18, 2020
@pmmmwh pmmmwh deleted the fix/window-check branch July 18, 2020 02:22
@chenbin92 chenbin92 mentioned this pull request Sep 20, 2020
Merged
@SebastienGllmt SebastienGllmt mentioned this pull request Nov 22, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pmmmwh pmmmwh

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@pmmmwh