Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: revamp socket URL handling with currentScript source #133

Merged
merged 7 commits into from
Jul 8, 2020

Conversation

pmmmwh
Copy link
Owner

@pmmmwh pmmmwh commented Jul 6, 2020

This fixes #105. It partially reverts changes in #106 because I was wrong about some assumptions on Webpack's __resourceQuery.

This change keeps IE11 compatibility for everyone other than WDS users (This is because, even if they polyfill URL, we will always run before the polyfill - unconfirmed though). All code with usage of the URL constructor is self-contained within WDSSocket.

Edit:
I've pulled the trigger to expand the scope of this.

Additional features resolves:
Fixes #30
Fixes #100

@pmmmwh pmmmwh added the bug Something isn't working label Jul 6, 2020
@pmmmwh pmmmwh self-assigned this Jul 6, 2020
@pmmmwh pmmmwh mentioned this pull request Jul 6, 2020
@pmmmwh
Copy link
Owner Author

pmmmwh commented Jul 7, 2020

Hmmmm this change will make further changes addressing resource query parsing much more difficult.

I was right in #106 about what I wanted to do - maybe I should just go ahead and handle #30 and #100 altogether ...

@pmmmwh pmmmwh changed the title fix: move resource query parsing back to entry feat: revamp socket URL handling with currentScript source Jul 7, 2020
@pmmmwh pmmmwh merged commit be5b0c4 into main Jul 8, 2020
@pmmmwh pmmmwh deleted the fix/resource-query branch July 8, 2020 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iframe errors Get websocket port from document.currentScript if possible
1 participant