fix: ensure signature function don't share identity with stubs (#505)

pmmmwh · Sep 13, 2021 · 61985e1 · 61985e1
1 parent f3990a5
commit 61985e1
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 5 deletions.
diff --git a/lib/utils/getRefreshGlobal.js b/lib/utils/getRefreshGlobal.js
@@ -71,7 +71,9 @@ function getRefreshGlobal(
           `${refreshGlobal}.runtime.register(type, typeId);`,
         ])}`,
         '',
-        `${refreshGlobal}.signature = ${refreshGlobal}.runtime.createSignatureFunctionForTransform;`,
+        `${refreshGlobal}.signature = ${RuntimeTemplate.returningFunction(
+          `${refreshGlobal}.runtime.createSignatureFunctionForTransform()`
+        )};`,
         '',
         `${refreshGlobal}.cleanup = ${RuntimeTemplate.basicFunction('cleanupModuleId', [
           // Only cleanup if the module IDs match.

diff --git a/test/unit/getRefreshGlobal.test.js b/test/unit/getRefreshGlobal.test.js
@@ -33,7 +33,7 @@ describe('getRefreshGlobal', () => {
 			__webpack_require__.$Refresh$.runtime.register(type, typeId);
 		}
 
-		__webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;
+		__webpack_require__.$Refresh$.signature = function() { return __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform(); };
 
 		__webpack_require__.$Refresh$.cleanup = function(cleanupModuleId) {
 			if (currentModuleId === cleanupModuleId) {
@@ -94,7 +94,7 @@ describe('getRefreshGlobal', () => {
 			__webpack_require__.$Refresh$.runtime.register(type, typeId);
 		}
 
-		__webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;
+		__webpack_require__.$Refresh$.signature = () => (__webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform());
 
 		__webpack_require__.$Refresh$.cleanup = (cleanupModuleId) => {
 			if (currentModuleId === cleanupModuleId) {

diff --git a/test/unit/makeRefreshRuntimeModule.test.js b/test/unit/makeRefreshRuntimeModule.test.js
@@ -83,7 +83,7 @@ __webpack_require__.$Refresh$ = {
 			__webpack_require__.$Refresh$.runtime.register(type, typeId);
 		}
 
-		__webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;
+		__webpack_require__.$Refresh$.signature = function() { return __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform(); };
 
 		__webpack_require__.$Refresh$.cleanup = function(cleanupModuleId) {
 			if (currentModuleId === cleanupModuleId) {
@@ -162,7 +162,7 @@ __webpack_require__.$Refresh$ = {
 			__webpack_require__.$Refresh$.runtime.register(type, typeId);
 		}
 
-		__webpack_require__.$Refresh$.signature = __webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform;
+		__webpack_require__.$Refresh$.signature = () => (__webpack_require__.$Refresh$.runtime.createSignatureFunctionForTransform());
 
 		__webpack_require__.$Refresh$.cleanup = (cleanupModuleId) => {
 			if (currentModuleId === cleanupModuleId) {