Fix some print statements and update OpenPMIx header parsing #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jjhursey Sorry, I cannot get the |
jjhursey
requested changes
Jan 24, 2023
We are using Python3, but the print statements are a mix of Python2 and 3 formats - so let's get everything into Python3. The OpenPMIx header includes some functions that return types (e.g., pmix_byte_object_t*) - the current parsing logic ignores those entries, so let's update to include them. This includes the following formats: const <type>* <fn> <type>* <fn> <type>** <fn> <type> *<fn> <type> **<fn> This picked up a number of previously overlooked exceptions. Signed-off-by: Ralph Castain <[email protected]>
|
Updated per comments |
jjhursey
approved these changes
Jan 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using Python3, but the print statements are a mix of
Python2 and 3 formats - so let's get everything into Python3.
The OpenPMIx header includes some functions that return
types (e.g., pmix_byte_object_t*) - the current parsing logic
ignores those entries, so let's update to include them.
This includes the following formats:
This picked up a number of previously overlooked exceptions.
Signed-off-by: Ralph Castain [email protected]