Issue 175 Sharing basics #393
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will be squashed eventually but doing this strange ordering in multiple commits to make sure that we can most easily see what changed. Signed-off-by: [email protected]
The chapter on NonReserved_Keys is going away. The final location is a new chapter called SharingBasics that goes over the basics of how applications share data. We then present the idea that there is some "already shared data" in the form of reserved keys in that chapter. This can all get collapsed into a simpler commit when we merge, but doing it this way helps with viewing how text changed. Signed-off-by: [email protected]
The final move to its new location happens in another PR The removal of Synchronization material happens in another PR The removal of the Query material happens in another PR This PR reworks the material of Chap_API_NonReserved_Keys and the PMIx_Get API presentation into a new consolidated presentation that gives a full overview of how to put/get data using PMIx and leaves the reserved keys entirely for its own chapter. Signed-off-by: [email protected]
dsolt
force-pushed
the
sharing_basics
branch
2 times, most recently
from
6203d87 to
d615424
Compare
Signed-off-by: [email protected]
|
Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal. Here are the meanings for the emojis: |
jjhursey
added
Eligible
jjhursey
reviewed
Feb 7, 2022
jjhursey
reviewed
Feb 7, 2022
jjhursey
reviewed
Feb 7, 2022
jjhursey
reviewed
Feb 7, 2022
jjhursey
reviewed
Feb 7, 2022
jjhursey
reviewed
Feb 7, 2022
jjhursey
reviewed
Feb 7, 2022
jjhursey
reviewed
Feb 7, 2022
dsolt
commented
Feb 7, 2022
dsolt
commented
Feb 7, 2022
dsolt
commented
Feb 7, 2022
Missing the use of refapi and ac/acp macros Some minor text changes. Signed-off-by: [email protected]
Account for bad merges which missed them. Signed-off-by: [email protected]
|
pmix-standard-sharing-basics_new.pdf Here is a pdf showing the changes to this chapter with green highlighting for new text, red for changed text and grey for moved text. |
jjhursey
reviewed
Feb 15, 2022
| support the \refterm{instant on} option) or where the host environment does not | ||
| provide a required piece of data. Other than the prefix, there are no | ||
| restrictions on the use or content of non-reserved keys. | ||
|
|
There was a problem hiding this comment.
Question: Can you have a key "foo" defined in both the LOCAL and REMOTE scopes possibly with different values?
Answer:
Believe that is not allowed. Need to confirm that this clarification is preserved - possibly in the scope section.- Actually, it is allowed to have the key posted to both scopes.
dsolt
commented
Feb 17, 2022
chapter xxx -> Chapter xxx
as explained in \ref{xxx} -> as explained in Chapter \ref{xxx} (or Section \ref{xxx})
many uses of PMIx functions without using the correct \refapi macro
Get rid of extraneous text: [Reference to publish/lookup chapter].
Get rid of extraneous ')' character
Signed-off-by: [email protected]
Co-authored-by: Josh Hursey <[email protected]>
|
PMIx ASC 1Q 2022
|
|
PMIx ASC 2Q 2022
|
jjhursey
added
the
Accepted as Stable
|
Rebased version in #405 |
|
Closing in favor of #405 - which has the same changes, but rebased |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.