Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Final touchups to PMIx_Get and PMIx_server_init attributes #294

Merged
merged 1 commit into from
Oct 14, 2020

Conversation

rhc54
Copy link
Member

@rhc54 rhc54 commented Oct 13, 2020

Provide the ability to request pointers to values, filling in of a
provided value struct address, as well as the default return of a newly
malloc'd struct. Clarify that "success" means the data was returned in
the form requested - do not return it as something different.

Remove the "slot" definition per WG discussion

Signed-off-by: Ralph Castain [email protected]

Provide the ability to request pointers to values, filling in of a
provided value struct address, as well as the default return of a newly
malloc'd struct. Clarify that "success" means the data was returned in
the form requested - do not return it as something different.

Remove the "slot" definition per WG discussion

Signed-off-by: Ralph Castain <[email protected]>
@rhc54 rhc54 added this to the PMIx v4 Standard milestone Oct 13, 2020
@rhc54 rhc54 requested a review from jjhursey October 13, 2020 16:01
@rhc54
Copy link
Member Author

rhc54 commented Oct 13, 2020

@jjhursey I believe this completes v4!!

Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. I like the new attribute name for returning a pointer to the data. That makes it more clear what's happening.

@jjhursey jjhursey merged commit fec1f42 into pmix:v4 Oct 14, 2020
@jjhursey jjhursey mentioned this pull request Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants