-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify a cospawn pause section #275
Conversation
WIP label because I want to show someone the diff before opening it for general review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still feels a little awkward, doesn't it? What I think we want to say is that any attributes to pause the job will only be applied to the apps that are not flagged as "debugger", yes? I see no reason why we wouldn't allow the launcher to pause the application procs, do you?
The prior sentence was a bit confusing as it could be read to imply that if you colaunch then you cannot pause the application which I don't think is what we wanted.
I think you are correct that a better wording here might be more along the lines of:
|
Agreed - that sounds much more accurate. Original version was poorly written by me. |
79f7243
to
37c44ba
Compare
I pushed the updated language. I think this is ready for review now. |
99f2472
to
0c919fe
Compare
Signed-off-by: Joshua Hursey <[email protected]> Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Joshua Hursey <[email protected]>
0c919fe
to
7ce0c71
Compare
PR has now been updated to clarify both the co-launch and co-spawn cases regarding the pausing of the application. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That got it - thanks!
No description provided.