Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify a cospawn pause section #275

Merged
merged 2 commits into from
Sep 3, 2020
Merged

Clarify a cospawn pause section #275

merged 2 commits into from
Sep 3, 2020

Conversation

jjhursey
Copy link
Member

@jjhursey jjhursey commented Sep 1, 2020

No description provided.

@jjhursey jjhursey added the WorkInProgress Work In Progress label Sep 1, 2020
@jjhursey
Copy link
Member Author

jjhursey commented Sep 1, 2020

WIP label because I want to show someone the diff before opening it for general review.

Copy link
Member

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still feels a little awkward, doesn't it? What I think we want to say is that any attributes to pause the job will only be applied to the apps that are not flagged as "debugger", yes? I see no reason why we wouldn't allow the launcher to pause the application procs, do you?

@jjhursey
Copy link
Member Author

jjhursey commented Sep 1, 2020

The prior sentence was a bit confusing as it could be read to imply that if you colaunch then you cannot pause the application which I don't think is what we wanted.

Note that this method for starting the debugger precludes the use of \ac{PMIx} attributes to \emph{pause} the application prior to attaching the debugger.

I think you are correct that a better wording here might be more along the lines of:

Note that \ac{PMIx} job \emph{pause} attributes (e.g., \refattr{PMIX_DEBUG_STOP_IN_INIT}) do not apply to applications where the \refattr{PMIX_DEBUGGER_DAEMONS} attribute set to true.

@rhc54
Copy link
Member

rhc54 commented Sep 1, 2020

Agreed - that sounds much more accurate. Original version was poorly written by me. ☹️

@jjhursey jjhursey removed WorkInProgress Work In Progress labels Sep 3, 2020
@jjhursey jjhursey marked this pull request as ready for review September 3, 2020 16:14
@jjhursey jjhursey added this to the PMIx v4 Standard milestone Sep 3, 2020
@jjhursey
Copy link
Member Author

jjhursey commented Sep 3, 2020

I pushed the updated language. I think this is ready for review now.

Chap_API_Tools.tex Outdated Show resolved Hide resolved
Signed-off-by: Joshua Hursey <[email protected]>
Signed-off-by: Ralph Castain <[email protected]>
Signed-off-by: Joshua Hursey <[email protected]>
@jjhursey
Copy link
Member Author

jjhursey commented Sep 3, 2020

PR has now been updated to clarify both the co-launch and co-spawn cases regarding the pausing of the application.

Copy link
Member

@rhc54 rhc54 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That got it - thanks!

@rhc54 rhc54 merged commit 543107f into pmix:master Sep 3, 2020
@jjhursey jjhursey deleted the c-tool-pause branch September 4, 2020 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants