Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: allow major text changes to ship in minor releases #36

Merged
merged 2 commits into from
May 12, 2022
Merged

RFC: allow major text changes to ship in minor releases #36

merged 2 commits into from
May 12, 2022

Conversation

abouteiller
Copy link
Contributor

Let the PR Author decide what is the target release for their PR, and
give the ASC flexibility in accepting the proposal to the next major
(rather than minor) release, without pushing back the proposal.

@abouteiller abouteiller added the Governance Modification to governance rules label Dec 2, 2021
@abouteiller abouteiller self-assigned this Dec 2, 2021
@jjhursey jjhursey added the Proposed Ready for review label Dec 9, 2021
jjhursey
jjhursey reviewed Dec 9, 2021
View reviewed changes
Copy link
Member

@jjhursey jjhursey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor typo. Generally I think this is fine. It gives the ASC a bit more power to include descriptive items in minor releases at their discretion. Since there is already a 2 vote sequence to get things in there is plenty of time for folks to review and consider the semantic implications.

pmix_governance.tex Outdated Show resolved Hide resolved
@abouteiller
Copy link
Contributor Author

Please use emoji reactions ON THIS COMMENT to indicate your position on this proposal.

  • You do not need to vote on every proposal
  • If you have no opinion, don't vote - that is also useful data
  • If you've already commented on this issue, please still vote so
    we know your current thoughts
  • Not all proposals solve exactly the same problem, so we may end
    up accepting proposals that appear to have some overlap
    This is not a binding majority-rule vote, but it will be a very
    significant input into the corresponding ASC decision.

Here are the meanings for the emojis:

  • Hooray or Rocket: I support this so strongly that I
    want to be an advocate for it
  • Heart: I think this is an ideal solution
  • Thumbs up: I'd be happy with this solution
  • Confused: I'd rather we not do this, but I can tolerate it
  • Thumbs down: I'd be actively unhappy, and may even consider
    other technologies instead
    If you want to explain in more detail, feel free to add another
    comment, but please also vote on this comment.

@abouteiller abouteiller force-pushed the majortext-targetrelease branch from 96e0143 to d29db56 Compare January 4, 2022 23:28
kathrynmohror
kathrynmohror reviewed Jan 4, 2022
View reviewed changes
pmix_governance.tex Outdated Show resolved Hide resolved
@jjhursey jjhursey added the Eligible Eligible for consideration by ASC label Jan 13, 2022
@abouteiller abouteiller force-pushed the majortext-targetrelease branch 2 times, most recently from 0b48215 to 3300ea7 Compare January 14, 2022 21:19
@abouteiller
Copy link
Contributor Author

pmix_governance.pdf

this is a latexdiff version for those that find it easier to read.

@jjhursey
Copy link
Member

jjhursey commented Mar 7, 2022

PMIx ASC 1Q 2022

  • Passed the first vote: 11 yes / 0 no / 0 abstain
  • This is eligible for a second vote in the 2Q 2022 ASC quarterly meeting

@jjhursey jjhursey added the First Vote Passed ASC first vote passed label Mar 7, 2022
@jjhursey
Copy link
Member

PMIx ASC 2Q 2022

  • Passed the second vote: 11 yes / 0 no / 0 abstain
  • Will be merged into the next release

@jjhursey jjhursey added the Accepted ASC second vote passed. Accepted! label May 12, 2022
abouteiller and others added 2 commits May 12, 2022 14:21
@abouteiller @jjhursey
Let the PR Author decide what is the target release for their PR, and
caa7431 
give the ASC flexibility in accepting the proposal to the next major
(rather than minor) release, without pushing back the proposal.

Signed-off-by: Aurélien Bouteiller <[email protected]>
@abouteiller @kathrynmohror @jjhursey
Update pmix_governance.tex
5ad0d60 
Signed-off-by: Aurélien Bouteiller <[email protected]>
Co-authored-by: Kathryn Mohror <[email protected]>
@jjhursey jjhursey force-pushed the majortext-targetrelease branch from 3300ea7 to 5ad0d60 Compare May 12, 2022 19:21
@jjhursey
Copy link
Member

I rebased this PR to prepare for the merge. No text changes.

@jjhursey jjhursey merged commit c0f3cea into pmix:master May 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kathrynmohror kathrynmohror kathrynmohror left review comments

@jjhursey jjhursey jjhursey approved these changes

Assignees

@abouteiller abouteiller

Labels
Accepted ASC second vote passed. Accepted! Eligible Eligible for consideration by ASC First Vote Passed ASC first vote passed Governance Modification to governance rules Proposed Ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abouteiller @jjhursey @kathrynmohror