Bump docker images versions #667
Conversation
lukaszstolarczuk
force-pushed
the
bump-docker-images-versions
branch
2 times, most recently
from
0e09420 to
fd0be33
Compare
lukaszstolarczuk
force-pushed
the
bump-docker-images-versions
branch
from
fd0be33 to
b1e39e3
Compare
|
images' versions will be updated to LTS versions on all branches. |
There was a problem hiding this comment.
Reviewable status: 0 of 11 files reviewed, all discussions resolved
|
This will be most likely merged after #731 (into master/stable-1.2...?) |
lukaszstolarczuk
force-pushed
the
bump-docker-images-versions
branch
from
b1e39e3 to
1c3ec1d
Compare
lukaszstolarczuk
force-pushed
the
bump-docker-images-versions
branch
from
1c3ec1d to
551a650
Compare
|
It's re-based, fixed where needed and ready for review. |
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @lukaszstolarczuk)
utils/docker/build.sh, line 101 at r1 (raw file):
fi # Only check style on Ubuntu, since it has req. clang-format version (and only if it isn't explicitly turned off)
Instead of this conditonal, cannot we just set CHECK_CPP_STYLE parameter in gha.yml for appropriate system?
lukaszstolarczuk
force-pushed
the
bump-docker-images-versions
branch
from
551a650 to
356c3b3
Compare
There was a problem hiding this comment.
Reviewable status: 0 of 4 files reviewed, 1 unresolved discussion (waiting on @igchor)
utils/docker/build.sh, line 101 at r1 (raw file):
Previously, igchor (Igor Chorążewicz) wrote…
Instead of this conditonal, cannot we just set CHECK_CPP_STYLE parameter in gha.yml for appropriate system?
Done. Good idea.
There was a problem hiding this comment.
Reviewed 1 of 4 files at r1, 2 of 3 files at r3.
Reviewable status: 3 of 4 files reviewed, all discussions resolved
lukaszstolarczuk
force-pushed
the
bump-docker-images-versions
branch
from
356c3b3 to
380cb14
Compare
|
We were missing some fix for clang-format names (cherry-picked from master branch). |
There was a problem hiding this comment.
Reviewed 1 of 3 files at r3, 3 of 3 files at r4.
Reviewable status:complete! all files reviewed, all discussions resolved
This PR also change, that cpp_style_check is run only on Ubuntu, because it has proper clang-format package version (9.0)
It's based on #757
This change is