-
Notifications
You must be signed in to change notification settings - Fork 510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: disable avx512f tests (pmem2_mem_ext) under Valgrind #5658
Conversation
Disable avx512f tests until Valgrind until Valigrind will provide support for avx512f instruction. See: pmem#5640 Signed-off-by: Tomasz Gromadzki <[email protected]>
Signed-off-by: Tomasz Gromadzki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
src/test/pmem2_mem_ext/TESTS.py
line 119 at r2 (raw file):
# All tests with variant VARIANT_AVX512F are disabled under Valgrind # until the issue https://github.com/pmem/pmdk/issues/5640 is fixed.
Unorthodox comment indentation.
Codecov Report
@@ Coverage Diff @@
## stable-1.13 #5658 +/- ##
===============================================
- Coverage 74.27% 74.26% -0.01%
===============================================
Files 145 145
Lines 22131 22131
Branches 3705 3705
===============================================
- Hits 16438 16436 -2
- Misses 5693 5695 +2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @grom72)
Signed-off-by: Tomasz Gromadzki <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @janekmi and @osalyk)
src/test/pmem2_mem_ext/TESTS.py
line 119 at r2 (raw file):
Previously, janekmi (Jan Michalski) wrote…
Unorthodox comment indentation.
Done.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @janekmi)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @grom72)
Disable avx512f tests (pmem2_mem_ext) until Valigrind will provide support for avx512f instruction.
See: #5640
This change is