Init fixes #284
Merged
Init fixes #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes problems identified in #282 and #283. The main change is that extended source initializations don't run the simple linear solver to get the best spectrum given their own morphology and the observation. Instead, we have been recommending using
set_spectrum_to_match, which solves for the best-fit spectrum given all morphologies in the scene. So, it's entirely sufficient, and probably safer in case of close blends, to initialize with the peak pixel.As for #282, the linear solver now masks redundant components and throws an errors message when the problem occurs, so that the user can e.g. remove that component. This is probably the best we can do without knowing why the problem occurred in the first place.