Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to pip==22.3 #99

Merged
merged 2 commits into from
Oct 23, 2022
Merged

Update to pip==22.3 #99

merged 2 commits into from
Oct 23, 2022

Conversation

pmeier
Copy link
Owner

@pmeier pmeier commented Oct 23, 2022

The only thing that changed for us is that SearchScope got a new no_index: bool parameter. See pypa/pip#11276.

This corresponds to the --no-index flag of pip install

--no-index Ignore package index (only looking at --find-links URLs instead).

Since we always operate with indices for PyTorch distributions, we can simply hardcode it to False.

@codecov
Copy link

codecov bot commented Oct 23, 2022

Codecov Report

Merging #99 (2eb8fd2) into main (eda21f3) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main     #99   +/-   ##
=====================================
  Coverage   83.7%   83.7%           
=====================================
  Files          5       5           
  Lines        351     351           
=====================================
  Hits         294     294           
  Misses        57      57           
Flag Coverage Δ
unit 83.7% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
light_the_torch/_patch.py 75.6% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pmeier pmeier merged commit 28a795a into main Oct 23, 2022
@pmeier pmeier deleted the pip-22.3 branch October 23, 2022 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant