Insteon device log verbosity #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If we don't remove the code now, we will likely never do it.
ALDB objects have no real name, and as such, a user would not be able to add them to a debug line in the ini. Moreover, if a user puts a device in the debug line, they likely expect to get all relevant messages, including ALDB messages for this device. Removed debuglevel routine as it is unnecessary.
Neither the Insteon Manager nor the non-object oriented Insteon.pm have user friendly names that can be put into the debug parameter. As a result adding a debuglevel routine which really just resulted in returning the global insteon debug level only complicated things.
…eInterface Trying to attach the debug message to the most logical object. Whenever possible, trying to avoid having the PLM be the "catch-all" object.
Remove debuglevel routine, messages have no human readable names. All calls should be to the relevant object. Calls to X10 items are tricky, x10 items are defined outside of BaseObject and so do not inherit the necessary debuglevel routine (unless it is expanded to Generic_Item at some future date)
Attempt to remove as many messages from the PLM as possible. Avoid using it like a "catch-all". This is particularly difficult for incoming messages.
…_PLM Moving to Generic_Item so that it will work properly with X10 items, also allows for expansion into other object types.
pmatis
added a commit
that referenced
this pull request
Nov 10, 2013
Whoah, you were busy! It looks good to me, based on my quick review. I think you caught a few things that I missed, like selecting the correct object, rather than $self all the time. Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started out making a few changes, and well it just grew.
See some of my notes in the commits.