Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Chacha20" #50

Merged
merged 1 commit into from
Nov 19, 2024
Merged

Revert "Chacha20" #50

merged 1 commit into from
Nov 19, 2024

Conversation

0xJepsen
Copy link
Contributor

@0xJepsen 0xJepsen commented Nov 19, 2024

Reverts #49

Merging this will revert the changes in made from merging the chacha20 branch. Needs an approval before merging. Feel free to merge after aproved.

@0xJepsen 0xJepsen marked this pull request as ready for review November 19, 2024 14:56
Copy link
Contributor

@Autoparallel Autoparallel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reverting this so we can get a proper review

@Autoparallel Autoparallel merged commit 8aa8b08 into main Nov 19, 2024
3 checks passed
@Autoparallel Autoparallel deleted the revert-49-chacha20 branch November 19, 2024 15:50
0xJepsen added a commit that referenced this pull request Nov 19, 2024
@0xJepsen 0xJepsen mentioned this pull request Nov 19, 2024
0xJepsen added a commit that referenced this pull request Nov 20, 2024
0xJepsen added a commit that referenced this pull request Nov 22, 2024
* Revert "Revert "Chacha20" (#50)"

This reverts commit 8aa8b08.

* Update circuits/test/chacha20/chacha20-nivc.test.ts

Co-authored-by: Colin Roberts <[email protected]>

* add back aes artifacts

* put aes back in full test

* artifact path and docs

* refactor tests to be more explicit

---------

Co-authored-by: Colin Roberts <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants