-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: NIVC circuits + tests #96
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passing for `parse` and for initial object masking. However, when the value is not an object starting with `{` we don't handle this correctly. We need to handle the case that it is a `[` or `"` or a number, ideally.
@lonerapier this is ready for review. I think the last steps are:
|
Found unused signals with the circom-witnesscalc `build-circuit` binary. These are now removed.
`HTTPParseAndLockStartLine` had unused signals. I set these properly now.
lonerapier
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
onto NIVC we go!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completed Work
This PR addresses:
OLD TODOs
Current Goals and TODOs
Most of the work is done, only a few bugs, tests, and upgrades remain.
Get the NIVC circuits in this repo, properly tested, and fully functional (in as far as the parsers themselves are).
Notes
Most of the (currently) 13K lines change is storing JSON. We can remove this JSON storage later and chain these together using
circuit.compute(input, ["step_out"])
and taking the output from there and using it for the subsequent input.I made JSON files now because I wanted temporary storage for introspection on the values.