Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: repo cleaning, remove unused code paths #84

Merged
merged 16 commits into from
Sep 23, 2024
Merged

chore: repo cleaning, remove unused code paths #84

merged 16 commits into from
Sep 23, 2024

Conversation

thor314
Copy link
Contributor

@thor314 thor314 commented Sep 20, 2024 •
edited by 0xJepsen
Loading

Closes #82.
Closes #81

  • add circomlib in circuits. Fixes circom-lsp path issues.
  • silence logs in tests
  • refactor codebase to remove unused code paths (in progress)

Note: All tests pass right now except the aes-gcm one because the new components need to get plugged in correctly. @devloper I assume you grabbed those?

@thor314
Copy link
Contributor Author

thor314 commented Sep 20, 2024 •
edited
Loading

work started, a lot of circom to clean up and de-duplicate.

There are several tests that fail to compile at the moment, most notably the aes-gcm circuit appears to be broken. @0xJepsen maybe we could fix this when we pair. repro: npx mocha -g aes-gcm

there were some other broken tests I was able to fix or remove for irrelevance, and I commented out a few particularly slow, irrelevant tests.

also, i added circom lib to our circuits area, which previously blocked my lsp from building. lmk if you'd prefer i just keep that gitignored.

@devloper
Copy link
Contributor

Why duplicate the circomlib code instead of importing?

@thor314
Copy link
Contributor Author

thor314 commented Sep 20, 2024

what do you mean @devloper

@devloper
Copy link
Contributor

This pull requests copies all of the circuits from circomlib into the repository. With circom you can specify an include flag, such as circom -l ./node_modules to include the circomlib circuits from an import. Circomkit itself does this by default. As a result there is no need to copy all the circuits.

@thor314
Copy link
Contributor Author

thor314 commented Sep 20, 2024

removed circomlib, added to my gitignore until further discussion

@0xJepsen 0xJepsen requested a review from devloper September 20, 2024 23:18
@0xJepsen 0xJepsen marked this pull request as ready for review September 20, 2024 23:20
@0xJepsen
Copy link
Contributor

@devloper What do you think about removing the client directory? Are we still using that?

thor314
thor314 commented Sep 20, 2024
View reviewed changes
circuits/test/aes/cipher.test.ts
@@ -65,3 +64,36 @@ describe("Cipher", () => {
);
});
});

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the deal here?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💩

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair

thor314
thor314 commented Sep 20, 2024
View reviewed changes
Copy link
Contributor Author

@thor314 thor314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems mostly renaming and code deletion, good stuff. I'm not sure what the inputs stuff was used for, pending tracy's approval

circuits/test/gfmulx/ghash_mulx.test.ts Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i thought you used mulx in your implementation?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do but not the one this tested / i moved it into the mul_test

@0xJepsen
Copy link
Contributor

0xJepsen commented Sep 20, 2024 •
edited
Loading

-4000, Death to complexity

@0xJepsen 0xJepsen merged commit 06fdebf into main Sep 23, 2024
2 checks passed
@0xJepsen 0xJepsen deleted the clean-up-your-room branch September 23, 2024 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xJepsen 0xJepsen 0xJepsen left review comments

@devloper devloper Awaiting requested review from devloper

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Unused Code Paths Test Organization
3 participants
@thor314 @devloper @0xJepsen