implement polyval #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deprecated or confusing code paths. In particular, tests updated for: - ghash - polyval - ghash_gfmul - hashkey_transform (used by ghash)
devloper
approved these changes
Sep 20, 2024
There was a problem hiding this comment.
Quick review LGTM! Given that main is not passing atm, I think we should go ahead and merge this polyval. This uses dramatically less constraints than the approach currently taken by ghash, so I think it's worth combining the two into one more efficient template.
| // } | ||
|
|
||
| // component MULX; | ||
| // MULX = polyval_GFMULX(); |
There was a problem hiding this comment.
This approach on the surface seems dramatically more efficient than the one currently used in Waylon's PR, because it only does this GFMULX once at the end.
Would be good to put our heads together and find a potentially combined approach of these code paths that is less constraint consumptive.
| @@ -0,0 +1,11 @@ | |||
| pragma circom 2.1.9; | |||
| include "polyval_gfmul.circom"; | |||
There was a problem hiding this comment.
delete file, one will be merged with the other PR
| @@ -22,6 +23,43 @@ template ParseLEBytes64() { | |||
| out <-- temp; | |||
| } | |||
|
|
|||
| // parse BE bits as bytes and log them. Assumes that the number of bytes logged is a multiple of 8. | |||
| template ParseAndLogBitsAsBytes(N_BYTES){ | |||
| out <-- ReverseByteHalves[1].out; | ||
|
|
||
| // component Logger3 = ParseAndLogBitsAsBytes(16); |
| @@ -36,6 +36,13 @@ template MUL() { | |||
| h[1] <== a[1]; | |||
| y[0] <== b[0]; | |||
| y[1] <== b[1]; | |||
| // component Loggers[4]; | |||
| @@ -82,52 +89,65 @@ template MUL() { | |||
| BMUL64_z[i+3].y <== h_r[i]; | |||
| zh[i] <== BMUL64_z[i+3].out; | |||
| } | |||
| // component Loggers_z[3]; | |||
| Xors_v[1].b <== __zh[2]; | ||
| v[2] <== Xors_v[1].out; | ||
| v[3] <== __zh[1]; | ||
|
|
||
| // component Loggers_v[4]; |
| @@ -161,6 +181,10 @@ template MUL() { | |||
| XorMultiples_L[0].inputs <== [v[1], LS_v[0].out, LS_v[1].out, LS_v[2].out]; | |||
| _v1 <== XorMultiples_L[0].out; | |||
|
|
|||
| // component Loggers_v2[4]; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implemented polyval to test ghash bug, rendered obsolete by waylon's recent PR, fixing ghash.
Also fixes a bug in polyval mul alg.