aes gcm #71
Merged
aes gcm #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devloper
approved these changes
Sep 16, 2024
| /// cipherText: encrypted ciphertext | ||
| /// authTag: authentication tag | ||
| /// | ||
| template AESGCM(l) { |
There was a problem hiding this comment.
AES_GCM_128 might be a more precise name, unless we want to modify this to very over key/iv size.
| incJ0.in <== J0; | ||
|
|
||
| // TODO(WJ 2024-09-09): stopping point | ||
| component gctr = GCTR(l, nk); |
There was a problem hiding this comment.
We should set it as a param to allow for many keys
| var v = 128 * Math.ceil(additionalData.length / 128) - additionalData.length; | ||
|
|
||
| // Step 5: Define a block, S | ||
| component ghash = GHASH(); |
There was a problem hiding this comment.
It seems like this is setup to handle "l" bits of plaintext, but this doesn't seems to accept a variable number of ciphertext bits.
| // generate plaintext blocks | ||
| // note to not use the last block of plaintext | ||
| // because it will be padded byt the toBlocks components | ||
| component plainTextBlocks = ToBlocks(INPUT_LEN); |
There was a problem hiding this comment.
Instead of moving between blocks and stream in circuit, would it make more sense to accept input as sequence of blocks?
|
nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.