-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
impl test for ghash, polyval #49
Conversation
pausing for tonight. Status: tasks: implement ghash
|
🤯 |
let bits = hexToBitArray("01000000000000000000000000000000"); | ||
for (let i = 0; i < mulXTestVectors.length; i++) { | ||
const expect = mulXTestVectors[i]; | ||
const _res = await circuit.compute({ in: bits }, ["out"]); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When working with @KaiGeffen we found that we can use circuit.expectPass({ in: TheInputVar }, { out: TheoutputVar });
to assert that the output is what we expect using the tools in curcomkit. This is nice because then you don't have to map the bits to the bigint like you do here
Updating the remaining scope of this PR:
next:
|
implement tests for ghash and polyval; see ref test vector in ietf spec. Tests should be both in terms of raw inputs to ghash/polyval, and testing implementations of polyval/ghash in terms of one another (relying on impl of
mulx
in #48)that is, given code:
write tests:
Closes #42
Closes #43
this pr does not implement ghash or polyval