Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deducer): configure local arch for pluto run on Mac #337

Merged
merged 1 commit into from
Aug 29, 2024

Conversation

jianzs
Copy link
Contributor

@jianzs jianzs commented Aug 29, 2024

Avoid unnecessary use of Docker for x86 pypi package downloads when executing pluto run on Mac. Previously, target architecture was set to x86 for all environments, leading to Docker usage on Mac. This change sets the target architecture to the local one during pluto run execution.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • CLI
  • Pyright Deducer

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

@jianzs jianzs added enhancement New feature or request deducer Deducer cli command-line interface 💡feature This issue or pull request is related to a new feature. labels Aug 29, 2024
Copy link

changeset-bot bot commented Aug 29, 2024

🦋 Changeset detected

Latest commit: 503b456

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@plutolang/pyright-deducer Patch
@plutolang/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Avoid unnecessary use of Docker for x86 pypi package downloads when executing pluto run on Mac. Previously, target architecture was set to x86 for all environments, leading to Docker usage on Mac. This change sets the target architecture to the local one during pluto run execution.
@jianzs jianzs force-pushed the feat-donnot-use-docker-on-mac branch from 0954930 to 503b456 Compare August 29, 2024 15:09
@jianzs jianzs merged commit 3db055d into pluto-lang:main Aug 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli command-line interface deducer Deducer enhancement New feature or request 💡feature This issue or pull request is related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant