Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deducer): parse index URLs from requirements.txt #298

Merged

Conversation

jianzs
Copy link
Contributor

@jianzs jianzs commented Jul 29, 2024

The deducer now parses index URLs specified in the project's root requirements.txt file. These URLs are utilized for dependency installation and are also included in the generated requirements.txt file.

1. Does this PR affect any open issues?(Y/N) and add issue references (e.g. "fix #123", "re #123".):

  • N
  • Y

2. What is the scope of this PR (e.g. component or file name):

  • Pyright Deducer

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

The deducer now parses index URLs specified in the project's root requirements.txt file. These URLs are utilized for dependency installation and are also included in the generated requirements.txt file.
@jianzs jianzs added deducer Deducer 💡feature This issue or pull request is related to a new feature. labels Jul 29, 2024
Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: d3be593

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@plutolang/pyright-deducer Patch
@plutolang/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@Peefy Peefy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jianzs jianzs merged commit 86cb072 into pluto-lang:main Jul 29, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deducer Deducer 💡feature This issue or pull request is related to a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants