Skip to content
This repository has been archived by the owner on Jan 8, 2024. It is now read-only.

Popup not appearing on the top of a page of a specific website (currently tested with chrome) #47

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

medamine980
Copy link

Changed z-index of the popup from '10000' to '10002' so that it stays at the top of the page (specifically tested with DoodStream, you can try it out with The Last Of Us TV Series)

@medamine980 medamine980 changed the title Popup not appearing on the top of a page of a specific website Popup not appearing on the top of a page of a specific website (currently tested with chrome) Nov 12, 2023
@ste-xx
Copy link
Member

ste-xx commented Jan 4, 2024

Hi,
I don't think increasing the z-index is a good solution, because the next page will set it to 10003 and the same error will occur.
Anyway, I will experiment with another solution:

@medamine980
Copy link
Author

Hello,

  1. Stacking context... well it will work if you set put the entire page (everything inside the ) in a new div and give that new div a position of relative and a low z-index, and set a higher z-index of the extension popup (ofcourse you would put the extension popup outside of the new created div so it will be an adjacent to it), that might theoretically work but it might introduce some unexpected behaviors especially if the page is using some kind of element which has position set to fixed so I wouldn't recommend this way.
  2. The popover html attribute is a new thing to me so I don't have a say in it.
  3. Another way is setting the z-index to the highest value possible.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants