Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update goreleaser config and add build ci job #496

Merged
merged 3 commits into from
Feb 22, 2024
Merged

fix: update goreleaser config and add build ci job #496

merged 3 commits into from
Feb 22, 2024

Conversation

floreks
Copy link
Member

@floreks floreks commented Feb 22, 2024 •
edited
Loading

Summary

  • Update goreleaser config
    • Get rid of dedicated console builds since UI is disabled by default.
    • Do not use CGO_ENABLED build as it is only required with embedded UI.
  • Add build job to the CI to build all binaries with goreleaser without releasing. It should allow us to avoid this kind of issues in the future.
  • Fix cloud image build

NOTE: We will need to rewire console to use standard binary (without console suffix)

Test Plan

GH CI

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@floreks floreks added the bug-fix This pull request fixes a bug label Feb 22, 2024
@michaeljguarino michaeljguarino merged commit 5ff4f46 into main Feb 22, 2024
14 of 15 checks passed
@michaeljguarino michaeljguarino deleted the fix/cd branch February 22, 2024 16:14
michaeljguarino pushed a commit that referenced this pull request Aug 28, 2024
@floreks @michaeljguarino
fix: update goreleaser config and add build ci job (#496)
83e17d6 
* fix: update goreleaser config and add build ci job to make sure goreleaser works

* update job name and remove web build

* update golangci-lint and fix cloud dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeljguarino michaeljguarino michaeljguarino approved these changes

@zreigz zreigz Awaiting requested review from zreigz zreigz is a code owner

@maciaszczykm maciaszczykm Awaiting requested review from maciaszczykm maciaszczykm is a code owner

Assignees
No one assigned
Labels
bug-fix This pull request fixes a bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@floreks @michaeljguarino