Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add dry run support for cd commands #484

Merged
merged 1 commit into from
Jan 18, 2024
Merged

add dry run support for cd commands #484

merged 1 commit into from
Jan 18, 2024

Conversation

zreigz
Copy link
Member

@zreigz zreigz commented Jan 18, 2024

Summary

Add dry run support for cd services create/update/describe

Labels

Test Plan

Checklist

  • If required, I have updated the Plural documentation accordingly.
  • I have added tests to cover my changes.
  • I have added a meaningful title and summary to convey the impact of this PR to a user.
  • I have added relevant labels to this PR to help with categorization for release notes.

@zreigz zreigz requested a review from maciaszczykm January 18, 2024 13:36
@zreigz zreigz added the enhancement New feature or request label Jan 18, 2024
@zreigz zreigz merged commit 3861ee3 into main Jan 18, 2024
10 of 14 checks passed
@zreigz zreigz deleted the dry-run branch January 18, 2024 14:33
michaeljguarino pushed a commit that referenced this pull request Aug 28, 2024
@zreigz @michaeljguarino
add dry run support for cd commands (#484)
c5c3acb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maciaszczykm maciaszczykm maciaszczykm approved these changes

@michaeljguarino michaeljguarino Awaiting requested review from michaeljguarino michaeljguarino is a code owner

@davidspek davidspek Awaiting requested review from davidspek

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zreigz @maciaszczykm