Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement fixture-changes from pw-beta, fix depreciation-warnings #489

Merged
merged 7 commits into from
Dec 29, 2023

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Dec 28, 2023

No description provided.

@bouwew bouwew requested a review from CoMPaTech December 28, 2023 11:27
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bouwew bouwew marked this pull request as ready for review December 28, 2023 11:29
@bouwew bouwew requested a review from a team as a code owner December 28, 2023 11:29
Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (11c0781) 100.00% compared to head (ff3b660) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #489   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines         2643      2643           
=========================================
  Hits          2643      2643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As indicated, be aware of false positives with the is not None

@bouwew bouwew merged commit 8addbd4 into main Dec 29, 2023
16 checks passed
@bouwew bouwew deleted the line-upfixtures branch December 29, 2023 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants