-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement limited access to gateway modes for Adam #486
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #486 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 11 11
Lines 2596 2643 +47
=========================================
+ Hits 2596 2643 +47 ☔ View full report in Codecov by Sentry. |
Not fixing the remaining Sonarcloud issue. Will be fixed when we split the code for legacy and non-legacy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should review the if statements, but other than that, seems solid to me.
I just login to sonar and set it to 'won't fix' with remark |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
Implements feature request #523