Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh adam_plus_anna_new userdata #482

Merged
merged 4 commits into from
Dec 23, 2023
Merged

Refresh adam_plus_anna_new userdata #482

merged 4 commits into from
Dec 23, 2023

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Dec 23, 2023

No description provided.

Copy link

codecov bot commented Dec 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5d0ad33) 100.00% compared to head (9f82bb9) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #482   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2691      2691           
=========================================
  Hits          2691      2691           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bouwew bouwew force-pushed the update_bouwew_data branch from 503f5c5 to 4c50499 Compare December 23, 2023 09:22
@bouwew bouwew force-pushed the update_bouwew_data branch from 4c50499 to 25d3230 Compare December 23, 2023 09:25
@bouwew bouwew marked this pull request as ready for review December 23, 2023 09:37
@bouwew bouwew requested a review from a team as a code owner December 23, 2023 09:37
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was actually trying to split the test-suite, but that PR is not ready, so I'll have to partially reapply what you did here. Do note that tests/test_smile.py expresses firmware 3.6 while the refresh is at 3.7.8

Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bouwew bouwew merged commit 391195f into main Dec 23, 2023
20 checks passed
@bouwew bouwew deleted the update_bouwew_data branch December 23, 2023 11:46
CoMPaTech added a commit that referenced this pull request Dec 23, 2023
CoMPaTech added a commit that referenced this pull request Dec 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants