Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Anna (without boiler) fw4.41 data #466

Merged
merged 14 commits into from
Dec 13, 2023
Merged

Add Anna (without boiler) fw4.41 data #466

merged 14 commits into from
Dec 13, 2023

Conversation

CoMPaTech
Copy link
Member

@CoMPaTech CoMPaTech commented Dec 10, 2023 •
edited
Loading

Todo:

  • Migrate/fix adam_jip
  • Cleanup older v4 tests / migrate to 4.4
  • Cleanup old firmware from fixtures (i.e. userdata/archive, tests/test_smile.py)
    • p1v3 Cleaned
    • anna_without_boiler Cleaned
    • others?

@CoMPaTech CoMPaTech added enhancement New feature or request smile Smile-related (i.e.networked Plugwise devices) quality labels Dec 10, 2023
@CoMPaTech CoMPaTech requested a review from a team as a code owner December 10, 2023 17:57
@codecov Codecov
Copy link

codecov bot commented Dec 10, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7ebc353) 100.00% compared to head (be2f046) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##              main      #466    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            6         6            
  Lines         2801      2691   -110     
==========================================
- Hits          2801      2691   -110

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@CoMPaTech
Copy link
Member Author

The modified adam_jip is now generated according to the others, e.g. becoming m_adam_jip. Purged first batch of older firmwares as discussed. Addition of the 'fixture generation only' is non-intrusive (used it to speed up validating fixtures without performing all device tests).

bouwew
bouwew approved these changes Dec 12, 2023
View reviewed changes
Copy link
Contributor

@bouwew bouwew left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add some info into CHANGELOG?

@bouwew
Copy link
Contributor

bouwew commented Dec 13, 2023

@CoMPaTech please have a final look at the stuff I've added.

@CoMPaTech
Copy link
Member Author

LGTM - do we need anything else (feel free to merge otherwise)

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@bouwew bouwew merged commit 309cffc into main Dec 13, 2023
20 checks passed
@bouwew bouwew deleted the awb_441 branch December 13, 2023 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bouwew bouwew bouwew approved these changes

Assignees

@CoMPaTech CoMPaTech

@bouwew bouwew

Labels
enhancement New feature or request quality smile Smile-related (i.e.networked Plugwise devices)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@CoMPaTech @bouwew