Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add device-items count to output #424

Merged
merged 52 commits into from
Oct 14, 2023
Merged

Add device-items count to output #424

merged 52 commits into from
Oct 14, 2023

Conversation

bouwew
Copy link
Contributor

@bouwew bouwew commented Oct 5, 2023

Could be used to detect changes to devices.

@bouwew bouwew requested a review from a team as a code owner October 5, 2023 18:25
@bouwew bouwew requested a review from CoMPaTech October 5, 2023 18:25
@codecov
Copy link

codecov bot commented Oct 5, 2023 •
edited
Loading

Codecov Report

Merging #424 (96f0684) into main (afffc9a) will not change coverage.
The diff coverage is 100.00%.

@@            Coverage Diff            @@
##              main      #424   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines         2722      2759   +37     
=========================================
+ Hits          2722      2759   +37
Files Coverage Δ
plugwise/__init__.py 100.00% <100.00%> (ø)
plugwise/constants.py 100.00% <100.00%> (ø)
plugwise/helper.py 100.00% <100.00%> (ø)
tests/test_smile.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bouwew bouwew mentioned this pull request Oct 5, 2023
Closed
bouwew added 25 commits October 8, 2023 11:25
@bouwew
Starting a different approach
5556a7c
@bouwew
Add item_count to gw_data
fe82798
@bouwew
Fix
68cb5b6
@bouwew
Full test-output
4972779
@bouwew
Init self_count to 0 at every start of data-collection
32f49b4
@bouwew
Add counting in P1 sensor-data collection
bb44d16
@bouwew
Update power_data_energy_diff() and move under class
2ccebec
@bouwew
Call via self
b1ce2e4
@bouwew
Fix ident
209892e
@bouwew
Add more debugging
80a1899
@bouwew
Remove wrong count-line
74478a9
@bouwew
More debug
304df8b
@bouwew
Try using len()
47cfc3a
@bouwew
Remove energy-diff counting and logging
05afb3a
@bouwew
Should be len(direct_data["sensors]}
7f07d3d
@bouwew
Add counts for availability and plugwise-notification
ccd0e16
@bouwew
Add counting in _create_legacy_gateway()
56fbc1e
@bouwew
Remove some debug-logging
1303238
@bouwew
Add item_count to GatewayData class
b3bab27
@bouwew
Add counting in _appliance_measurements()
edd726b
@bouwew
Add various more counting lines
292dfdf
@bouwew
Add counting in _update_for_cooling()
c9bc87d
@bouwew
Add checking-function
dff661a
@bouwew
Compare
cdd3fbf
@bouwew
Fix
e119e6f
@bouwew
Copy link
Contributor Author

bouwew commented Oct 8, 2023

@CoMPaTech the short solution was impossible to type so I went for a more difficult solution that needed no extra typing :)

CoMPaTech
CoMPaTech approved these changes Oct 12, 2023
View reviewed changes
Copy link
Member

@CoMPaTech CoMPaTech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still approved, just some small notes on discord + suggestion for follow-up PR

@bouwew bouwew merged commit 44ee74e into main Oct 14, 2023
@bouwew bouwew deleted the count branch October 14, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CoMPaTech CoMPaTech CoMPaTech approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bouwew @CoMPaTech