Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove !pattern.length for loading state #154

Merged

Conversation

TMSchipper
Copy link
Collaborator

What does it do?

Fix issue with not loading url patterns in bug report: issue-150

@TMSchipper TMSchipper added the bug Something isn't working label Jul 22, 2024
@TMSchipper TMSchipper requested a review from boazpoolman July 22, 2024 19:44
@TMSchipper TMSchipper self-assigned this Jul 22, 2024
Copy link

changeset-bot bot commented Jul 22, 2024

🦋 Changeset detected

Latest commit: 60b5eff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@pluginpal/webtools-core Minor
@pluginpal/webtools-addon-menus Major
@pluginpal/webtools-addon-redirects Major
@pluginpal/webtools-addon-sitemap Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov-commenter
Copy link

codecov-commenter commented Jul 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 0.96%. Comparing base (f16963c) to head (60b5eff).

Files Patch % Lines
...ges/core/admin/screens/Patterns/ListPage/index.tsx 0.00% 0 Missing and 1 partial ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@          Coverage Diff           @@
##           master    #154   +/-   ##
======================================
  Coverage    0.96%   0.96%           
======================================
  Files         189     189           
  Lines        2907    2907           
  Branches      396     396           
======================================
  Hits           28      28           
+ Misses       2708    2707    -1     
- Partials      171     172    +1     
Flag Coverage Δ
unit 0.96% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@boazpoolman boazpoolman merged commit cbac66c into master Jul 23, 2024
4 checks passed
@boazpoolman boazpoolman deleted the feature/150-bug-url-pattern-screen-is-not-being-loaded branch July 23, 2024 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants