-
-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature add hreflang x-default tag to sitemap #162
Feature add hreflang x-default tag to sitemap #162
Conversation
… hreflang x-default tag
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR @RomainGueffier.
Functionally it works perfect!
I just have a couple remarks on your code.
If you could implement those changes I'll get this merged and released asap :)
You can run
Sorry. Those |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
What does it do?
Add an additional link tag with hreflang x-default to improve locale detection fallback.
Add in settings form a select to save user preferences with 3 options:
When last option is selected, an extra text input field shows up to put a custom url.
Add translations for English and French
Extend default Test collection to add
slug
field in order to have better use cases to try feature.Why is it needed?
Improve SEO.
How to test it?
Run strapi with plugin installed. Open Sitemap plugin settings.
Outputs:
Related issue(s)/PR(s)
Closes #161
Tasks:
yarn docs:generate
mentioned in CONTRIBUTING.md.