-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Forbid synced configs to be edited in Admin panel #68
Comments
Hi @goodhoko. Thanks for yet another great feature request. I'm not sure if we have that much control from within a plugin. For returning an error when trying to update locked settings I think we have to write some kind of middleware. |
+1. We use this feature to import configs for different API's. We are running into this issue so we are not using the importOnBootstrap feature. One example:
So basically, if the state is |
@BabyDino That seems like a nice suggestion! I feel like it is a different feature then issue #68. |
Feature request
Summary
Add an option that makes it impossible to edit configs eligible for exporting from the Admin panel.
Why is it needed?
I'm using the config-sync plugin as outlined in the Workflow section of its documentation. I.e. I alter the configs locally, check the changes into git, and then import them on remote (staging/prod) environments.
Since my deploys to remote envs are fully automated I'm taking advantage of the
importOnBootstrap
option to import the changes automatically with every deploy. This causes any changes in the DB to be overwritten. This is ultimately correct, as the developer's (and hence the imported) config version should be the source of truth. However it can still cause confusion and/or trouble as users using the Admin panel may not know/understand their changes will disappear with the next deploy.Suggested solution(s)
The optimal solution is to have an option in the plugin's config that, when set to true, prevents any writes to configs eligible for exporting. This option can then be set depending on the environment.
Indicating that a config is locked in the Admin Panel GUI would be very nice, but simply returning an error after submit would work too, IMO.
The text was updated successfully, but these errors were encountered: