clean up HTML markup for dashboard widget #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove redundant for/id attributes from wrapped <label> tags * use <div> instead of <fieldset> as wrapper around settings * do not close <input> tags * add type attribute to refresh button
stklcode
force-pushed
the
fix/clean-widget-markup
branch
from
6cc04d4 to
7c3d969
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<label>tagsThe
<inputelements are are wrapped<label>, so the association is clear and no for/id mapping is required.For valid HTML the
<fieldset>should have a<legend>element. We might move the headline (<h3>) into the legend, but actually we only have one set of fields in the form, so additional semantic grouping is not necessary.We close the tags for number inputs, but not for checkboxes. Let's use the same way for all inputs.
Type attribute is required. All browsers tested seem to assume "submit" by default (otherwise the mechanism would not work), but we should make it explicit.