Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CSS to not overrule display property on collapsed widget #209

Merged
merged 2 commits into from
Jun 22, 2021

Conversation

stklcode
Copy link
Contributor

resolves #208

We could have used the shorthand selector #statify_dashboard:not(.closed) .inside, but this would be incompatible with the IE browser and we still claim to support WP versions that have not dropped the support yet. So we simply add another directive to overrule the selector.

Refactoring the stylesheet to not use IDs at all would be great, but for now I'd prefer a quick non-invasive fix.

@stklcode stklcode added the bug label May 28, 2021
@stklcode stklcode added this to the 1.8.3 milestone May 28, 2021
Copy link
Member

@florianbrinkmann florianbrinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@stklcode stklcode merged commit 7889a57 into develop Jun 22, 2021
@stklcode stklcode deleted the fix/208-closeable-widget branch June 22, 2021 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statify widget not collapsed
2 participants