fix AMP compatibility for Standard and Transitional mode (#181) #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Standard and Transitional mode use the "amp_analytics_entries" hook, Reader mode uses "amp_post_template_analytics". We only added a filter for the latter, so AMP compatibility was only available in Reader mode.
|
This works for me. 👍🏻 |
|
Great. Thanks for the quick feedback. I‘ll add a condition to remove the unnecessary scripts tomorrow (if nobody is faster), then we can rollout the fix. |
Scripts and inline JS get removed on pages served via AMP. While that's fine for Statify, because we do use a separate analytics hook, it raises warnings for invalid markup on every AMP page. We now detect AMP usage and skip embedding the script. Also the checks are updated to use the new amp_is_request() function introduced in AMP plugin 2.0 for future compatibility.
stklcode
force-pushed
the
fix/181-amp-compatibility
branch
from
23fc7c2 to
a19a01a
Compare
|
I've added the necessary check within the An earlier check, e.g. not register |
|
Also the check in |
Commonly used methods "beacon" and "xhrpost" are enabled by default, but as Statify doesn't work with "image", i.e. GET requests, we now specify the supported methods explicitly again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Standard and Transitional mode use the
amp_analytics_entrieshook, Reader mode usesamp_post_template_analytics.We only added a filter for the latter, so AMP compatibility was only available in Reader mode.