use wp_date() to fix possible date offset in WP 5.3 sites (#166) #167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #166.
Introduce a new wrapper function
Statify::parse_date( $date )that useswp_date()when available (WP 5.3+) with fallback to the previousdate_i18n()call.date_i18n()is a wrapper forwp_date()since WP 5.3 and tries to re-calculate the timezone offset. This clashes in several scenarios when the date (implicitly 00:00:00) is shifted back, s.t. the dashboard widget shows an offset of -1 day in these cases.