fix inconsistency between number of total visits and first date #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Date has been taken from the first data point of the output range while the total number of hits is directly requested from the database. Now the first date is also qeueried along with the taotal count.
stklcode
force-pushed
the
fix/totals-date-consistency
branch
from
e402be2 to
14fe501
Compare
patrickrobrecht
approved these changes
May 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially reported in WP support forums (German): https://wordpress.org/support/topic/zeige-gesamtzahlen-dashboard/
Date has been taken from the first data point of the output range while the total number of hits is directly requested from the database.
Apparently the shortcut of simply copying the first date in the output array (
$stats['visits'][0]['date']) was correct when #134 has been opened, but has become incorrect when #72 has finally been merged which split the display and storage range.Now the first date is also qeueried along with the total count.