move dark-mode styling into dashboard.css #278
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dark mode styling has been added inline using the "doing_dark_mode" hook which is no longer called in current plugin versions. Include the CSS definition directly into dashboard.css and deprecate the hook for adding inline styles.
|
Kudos, SonarCloud Quality Gate passed!
|
stklcode
force-pushed
the
feature/264-darkmode-css
branch
from
97cae5f to
78df528
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dark mode styling has been added inline using the "doing_dark_mode" hook which is no longer called in current plugin versions.
Include the CSS definition directly into dashboard.css and deprecate the hook for adding inline styles.
resolves #264
However: This does not apply to all "dark-mode" plugins and not even to all themes, because the icon has two different shades of gray and is not affected by most stylings that assume Dashicons are used here. We might prefer a different approach like #277