Return Window even when pixel measurements not reported in ioctl
#115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without the window we cannot calculate the grid columns properly, but set the column amount as one, which results the grid option not working in terminal emulators like Alacritty that do not support Kittys's terminal graphics protocol. This commit removes the pattern match and returns the supports_gfx boolean and window separately. Now when the window is returned the grid is properly rendered. Tested on Alacritty version `0.13.2`.
dhruvkb
changed the title
Window even when pixel measurements not reported in ioctl
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! 👋
I was trying out
pls, but unfortunately thegridoption does not work on my setup, which is using tmux and alacritty.Above is the current change, and below is the newest release version of
pls.Seems like without the window we cannot calculate the grid columns properly, but set the column amount as one, which results the grid option not working in terminal emulators like Alacritty that do not support Kittys's terminal graphics protocol.
This commit removes the pattern match and returns the supports_gfx boolean and window separately. Now when the window is returned the grid is properly rendered.
Tested on Alacritty version
0.13.2.