Missing legend keys on bar charts with zero data values #219
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #111 and #218 (duplicate).
See #218 for a detailed explanation of the issue and approach but the summary is that by filtering out zero-height bars before generating the legend, if a bar doesn't show in the first group of bars (because it has a value at or close to zero) it doesn't appear in the legend. To fix, remove this filter and add filtering just before the graphs are rendered.
I think this approach is better than #128 because with that method it appears that if a key has value 0 across the whole range covered by the graph, it will not appear in the legend. In our use case this is quite common as you can set the date range of the graph and some of the keys may have no data in them for certain periods of time. The key should still appear in the legend so it is clear that the value is zero, rather than just not included in the graph.