Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plotly 1.41.2 features #741

Merged
merged 1 commit into from
Sep 20, 2018
Merged

plotly 1.41.2 features #741

merged 1 commit into from
Sep 20, 2018

Conversation

dmt0
Copy link
Contributor

@dmt0 dmt0 commented Sep 12, 2018

Bumps plotly.js to v. 1.41.2 and adds all the features included in it.
Addresses #505
Closes #519

@dmt0 dmt0 self-assigned this Sep 12, 2018
@@ -89,6 +90,16 @@ const StyleLayoutPanel = (props, {localize: _}) => (
clearable={false}
/>
</PlotlySection>
<PlotlySection name={_('Click')} attr="dragmode">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this really dragmode? We already have that attr a couple of widgets up.

@@ -40,6 +40,8 @@ export function traceTypeToPlotlyInitFigure(traceType, gl = '') {
return {type: 'scatter' + gl, fill: 'tozeroy'};
case 'scatterpolar':
return {type: 'scatterpolar' + gl};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are trace should default to NOT specifying fill and to having stackgroup='Group 1'

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in area recognition, we also need to check for a stackgroup

@@ -40,6 +40,8 @@ export function traceTypeToPlotlyInitFigure(traceType, gl = '') {
return {type: 'scatter' + gl, fill: 'tozeroy'};
case 'scatterpolar':
return {type: 'scatterpolar' + gl};
case 'barpolar':
return {type: 'barpolar'};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

block not needed unless we tweak it

@dmt0 dmt0 force-pushed the 141 branch 2 times, most recently from 6884040 to 12f3fb4 Compare September 13, 2018 18:26
@nicolaskruchten
Copy link
Contributor

So looking at Percy, the orientation attr in the "Stacking" has appeared for a whole bunch of trace types other than scatter/line/area (bar, violin etc) ... can we make this a TraceTypeSection so it doesn't do that plz?

@nicolaskruchten
Copy link
Contributor

Woo!

Can we get a barpolar percy mock plz?

@@ -37,7 +38,7 @@ export function traceTypeToPlotlyInitFigure(traceType, gl = '') {
case 'scatter':
return {type: 'scatter' + gl, mode: 'markers', fill: 'none'};
case 'area':
return {type: 'scatter' + gl, fill: 'tozeroy'};
return {type: 'scatter' + gl, stackgroup: 1};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we make this mode: "lines" plz?

@nicolaskruchten
Copy link
Contributor

Blocked by plotly/plotly.js#3013

attr="barmode"
options={[{label: _('Stack'), value: 'stack'}, {label: _('Overlay'), value: 'overlay'}]}
/>
<NumericFraction label={_('Bars')} attr="bargap" showSlider />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's call this "Bar Padding" like we do in Style/Traces for bar

@dmt0 dmt0 force-pushed the 141 branch 2 times, most recently from 33264a9 to c47cdc4 Compare September 18, 2018 17:26
@dmt0 dmt0 changed the title plotly 1.41 features plotly 1.41.1 features Sep 18, 2018
@dmt0 dmt0 changed the title plotly 1.41.1 features plotly 1.41.2 features Sep 19, 2018
@nicolaskruchten nicolaskruchten merged commit 43f3d87 into master Sep 20, 2018
@nicolaskruchten
Copy link
Contributor

💃

@nicolaskruchten nicolaskruchten deleted the 141 branch September 20, 2018 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants