-
-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
plotly 1.41.2 features #741
Conversation
@@ -89,6 +90,16 @@ const StyleLayoutPanel = (props, {localize: _}) => ( | |||
clearable={false} | |||
/> | |||
</PlotlySection> | |||
<PlotlySection name={_('Click')} attr="dragmode"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this really dragmode
? We already have that attr a couple of widgets up.
src/lib/customTraceType.js
Outdated
@@ -40,6 +40,8 @@ export function traceTypeToPlotlyInitFigure(traceType, gl = '') { | |||
return {type: 'scatter' + gl, fill: 'tozeroy'}; | |||
case 'scatterpolar': | |||
return {type: 'scatterpolar' + gl}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are trace should default to NOT specifying fill and to having stackgroup='Group 1'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in area recognition, we also need to check for a stackgroup
src/lib/customTraceType.js
Outdated
@@ -40,6 +40,8 @@ export function traceTypeToPlotlyInitFigure(traceType, gl = '') { | |||
return {type: 'scatter' + gl, fill: 'tozeroy'}; | |||
case 'scatterpolar': | |||
return {type: 'scatterpolar' + gl}; | |||
case 'barpolar': | |||
return {type: 'barpolar'}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
block not needed unless we tweak it
6884040
to
12f3fb4
Compare
So looking at Percy, the |
Woo! Can we get a |
src/lib/customTraceType.js
Outdated
@@ -37,7 +38,7 @@ export function traceTypeToPlotlyInitFigure(traceType, gl = '') { | |||
case 'scatter': | |||
return {type: 'scatter' + gl, mode: 'markers', fill: 'none'}; | |||
case 'area': | |||
return {type: 'scatter' + gl, fill: 'tozeroy'}; | |||
return {type: 'scatter' + gl, stackgroup: 1}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we make this mode: "lines"
plz?
Blocked by plotly/plotly.js#3013 |
2c60123
to
2036d92
Compare
attr="barmode" | ||
options={[{label: _('Stack'), value: 'stack'}, {label: _('Overlay'), value: 'overlay'}]} | ||
/> | ||
<NumericFraction label={_('Bars')} attr="bargap" showSlider /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's call this "Bar Padding" like we do in Style/Traces for bar
33264a9
to
c47cdc4
Compare
💃 |
Bumps plotly.js to v. 1.41.2 and adds all the features included in it.
Addresses #505
Closes #519