Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new map options to px and update plotly.js/master at 056799dfc705a4533935ae3169cc94d35bc44830 #4726

Merged
merged 6 commits into from
Aug 29, 2024

Conversation

archmoj
Copy link
Contributor

@archmoj archmoj commented Aug 23, 2024

Related to plotly/plotly.js#7015.

@archmoj
Copy link
Contributor Author

archmoj commented Aug 23, 2024

cc: birkskyum

@LiamConnors LiamConnors requested a review from emilykl August 27, 2024 19:32
@LiamConnors
Copy link
Member

This looks good to me. Was there a particular example you couldn't get to render @archmoj

Copy link
Member

@ndrezn ndrezn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a deprecation warning for Mapbox traces similar to plotly/plotly.js#7087, but in this case have it appear in the Python console in addition to in the browser console?

@archmoj
Copy link
Contributor Author

archmoj commented Aug 27, 2024

Is it possible to add a deprecation warning for Mapbox traces similar to plotly/plotly.js#7087, but in this case have it appear in the Python console in addition to in the browser console?

If possible, that should be done in a separate PR.
This PR is already huge.

@ndrezn
Copy link
Member

ndrezn commented Aug 28, 2024

@archmoj makes sense to me -- opened #4730 to cover that case.

@archmoj
Copy link
Contributor Author

archmoj commented Aug 28, 2024

@LiamConnors Please take over this PR and once ready merge it into your doc PR or master?
I thought you may want to revert big commit of plotly.js update ba9c413 and just add the px parts to have viewable diffs. No?

@LiamConnors LiamConnors requested review from ndrezn and gvwilson August 29, 2024 14:40
@LiamConnors LiamConnors merged commit 24730c3 into maplibre-tests Aug 29, 2024
2 of 4 checks passed
@ndrezn ndrezn deleted the maplibre-tests_with-px branch August 29, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants