Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

idiomatically set zIndex when creating the Cartesian plot dragCover/coverSlip #92

Conversation

tlrdstd
Copy link
Contributor

@tlrdstd tlrdstd commented Dec 8, 2015

At work, I develop on Firefox 31. I found that this browser does not support setting z-index via style['z-index']. However, it works correctly with style.zIndex.

W3Schools (I know, I know...but I couldn't find a better reference for this) confirms that this is the expected, idiomatic behavior.

Firefox 38 seems to handle either approach correctly.

@etpinard
Copy link
Contributor

etpinard commented Dec 8, 2015

Looks good in Chrome 46.0.2490.86

But I suspect that @alexcjohnson originally put ['z-index'] there for a reason. Maybe other browsers only understand ['z-index'] ?

@alexcjohnson
Copy link
Collaborator

But I suspect that @alexcjohnson originally put ['z-index'] there for a reason.

Maybe I need to spend some more time on W3Schools :) @tlrdstd 's fix seems correct.

@etpinard
Copy link
Contributor

etpinard commented Dec 9, 2015

TODO:

  • Try in IE11

@etpinard
Copy link
Contributor

@tlrdstd I tested your patch in IE11. Great work. Thanks.

etpinard added a commit that referenced this pull request Dec 14, 2015
…ly_sets_zIndex

idiomatically set zIndex when creating the Cartesian plot dragCover/coverSlip
@etpinard etpinard merged commit eac41fe into plotly:master Dec 14, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants