Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for deprecated attribute gl3d.cameraposition (use gl3d.camera instead) #7217

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

emilykl
Copy link
Contributor

@emilykl emilykl commented Oct 7, 2024

Closes #7196

  • Drop support for deprecated attribute gl3d.cameraposition (use gl3d.camera instead)
  • Update mocks

@emilykl
Copy link
Contributor Author

emilykl commented Oct 7, 2024

@archmoj @LiamConnors Do we have docs anywhere explaining how to convert from the old cameraposition to the new camera format? If not, should we?

The conversion can be figured out by looking at this function.

],
"camera": {
"eye": {
"x": 0.8970225259545955,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aaaand we just know these numbers? :-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I used the existing conversion function before deleting it. :-)

But I'll admit I don't actually know what the numbers in the old format mean. The meaning of the new format is documented here.

@gvwilson gvwilson added feature something new P1 needed for current cycle labels Oct 8, 2024
Copy link
Contributor

@archmoj archmoj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💃

@LiamConnors
Copy link
Member

LiamConnors commented Oct 8, 2024

@archmoj @LiamConnors Do we have docs anywhere explaining how to convert from the old cameraposition to the new camera format? If not, should we?

The conversion can be figured out by looking at this function.

There's nothing currently in the docs. I'll write up a page that lists the deprecation removals and how to migrate.

@emilykl
Copy link
Contributor Author

emilykl commented Oct 8, 2024

I'll write up a page that lists the deprecation removals and how to migrate.

That would be fantastic -- thanks @LiamConnors !

@emilykl emilykl merged commit e4b3591 into master Oct 8, 2024
1 check passed
@emilykl emilykl deleted the drop-cameraposition branch October 8, 2024 18:30
@LiamConnors
Copy link
Member

@emilykl do you know which traces this was available on? I'm having trouble identifying exactly which ones.

@emilykl
Copy link
Contributor Author

emilykl commented Oct 9, 2024

@LiamConnors I believe it's just 3d surface plots (is that correct @archmoj?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature something new P1 needed for current cycle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

drop deprecated gl3d cameraposition in v3
4 participants