-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for deprecated attribute gl3d.cameraposition
(use gl3d.camera
instead)
#7217
Conversation
@archmoj @LiamConnors Do we have docs anywhere explaining how to convert from the old The conversion can be figured out by looking at this function. |
], | ||
"camera": { | ||
"eye": { | ||
"x": 0.8970225259545955, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
aaaand we just know these numbers? :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I used the existing conversion function before deleting it. :-)
But I'll admit I don't actually know what the numbers in the old format mean. The meaning of the new format is documented here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💃
There's nothing currently in the docs. I'll write up a page that lists the deprecation removals and how to migrate. |
That would be fantastic -- thanks @LiamConnors ! |
@emilykl do you know which traces this was available on? I'm having trouble identifying exactly which ones. |
@LiamConnors I believe it's just 3d surface plots (is that correct @archmoj?) |
Closes #7196
gl3d.cameraposition
(usegl3d.camera
instead)