New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop support for passing a string to the `title` attribute, and drop support for deprecated attributes `titlefont`, `titleposition`, `titleside`, and `titleoffset` #7212

Merged

emilykl merged 13 commits into master from drop-title-text-str

Oct 9, 2024

Contributor

emilykl commented Oct 7, 2024 •

edited

Loading

Closes: #7177

Drop support for passing a string to the title attribute (use title.text instead)
Drop support for deprecated titlefont attribute (use title.font instead)
Drop support for deprecated titleposition attribute (use title.position instead)
Drop support for deprecated titleside attribute (use title.side instead)
Drop support for deprecated titleoffset attribute (use title.offset instead)
Apply these changes apply to everywhere the above attributes appear(layout, colorbar, axis, etc.)

Also:

Remove jasmine tests corresponding to the removed attributes
Remove functions used for converting old attributes to new attributes

emilykl added 10 commits

October 4, 2024 12:27


          remove support for 'title' as string, and remove 'titlefont', 'titles…

e54e65c

…ide', 'titleoffset', and 'titleposition'


          update plot-schema

5cfe400


          update jasmine tests

174ec01


          update jasmine tests

d1a5f09


          remove deprecated title attributes from colorbar

e3d5abb


          update plot-schema

0f2fde9


          remove test for removed attribute

753858a


          update jasmine tests

b4d2bef


          draftlog

c0c64f6


          fix test

e948ff4

emilykl requested review from archmoj, gvwilson and marthacryan

October 7, 2024 15:08

archmoj reviewed

View reviewed changes

src/plots/gl3d/layout/axis_attributes.js Outdated Show resolved Hide resolved

archmoj reviewed

View reviewed changes

src/plots/layout_attributes.js Outdated Show resolved Hide resolved

archmoj reviewed

View reviewed changes

src/plots/polar/layout_attributes.js Outdated Show resolved Hide resolved

archmoj reviewed

View reviewed changes

src/plots/ternary/layout_attributes.js Outdated Show resolved Hide resolved

archmoj reviewed

View reviewed changes

src/traces/carpet/axis_attributes.js Outdated Show resolved Hide resolved

archmoj reviewed

View reviewed changes

src/traces/pie/attributes.js Outdated Show resolved Hide resolved


          remove empty '_deprecated' keys

cc5b9f9

Contributor Author

emilykl commented Oct 7, 2024

@archmoj Thanks very much for the review. I've removed the empty _deprecated keys. Do you have any other comments?


          update plot-schema

26129d9

gvwilson assigned emilykl

gvwilson added feature P1 labels

archmoj approved these changes

View reviewed changes

Contributor

archmoj left a comment

💃

Contributor

archmoj commented Oct 8, 2024

@emilykl Do you need my help resolving the conflicts with master?


          merge master

8a0362d

Contributor Author

emilykl commented Oct 8, 2024

@emilykl Do you need my help resolving the conflicts with master?

@archmoj Nope, all good!

Contributor

archmoj commented Oct 9, 2024

💃

emilykl merged commit 7916edf into master

1 check passed

emilykl deleted the drop-title-text-str branch

October 9, 2024 20:24

LiamConnors mentioned this pull request

Remove deprecated attributes from docs plotly/graphing-library-docs#326

Merged

emilykl mentioned this pull request

Re-add support for passing title as string #7230

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels