Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#6571 fix scatter3d marker opacity when marker.opacity is set to 0 #6581

Merged
merged 3 commits into from
Apr 26, 2023
Merged

#6571 fix scatter3d marker opacity when marker.opacity is set to 0 #6581

merged 3 commits into from
Apr 26, 2023

Conversation

dmyronuk
Copy link
Contributor

@dmyronuk dmyronuk commented Apr 25, 2023 •
edited by archmoj
Loading

Fixes #6571.

@dmyronuk dmyronuk changed the title fix: scatter3d marker opacity when marker.opacity is set to 0 #6581 fix scatter3d marker opacity when marker.opacity is set to 0 Apr 25, 2023
@dmyronuk dmyronuk changed the title #6581 fix scatter3d marker opacity when marker.opacity is set to 0 #6571 fix scatter3d marker opacity when marker.opacity is set to 0 Apr 25, 2023
@archmoj archmoj added bug something broken community community contribution status: reviewable labels Apr 25, 2023
@archmoj
Copy link
Contributor

archmoj commented Apr 25, 2023

Thanks very much for the bug report as well as the fix.
Please add draftlog/6581_fix.md as described in here.
After considering my comment and dropping fast-isnumeric import, this PR is good to go. 🚀

@dmyronuk dmyronuk requested a review from archmoj April 26, 2023 01:39
archmoj
archmoj reviewed Apr 26, 2023
View reviewed changes
draftlogs/6581_fix.md Outdated Show resolved Hide resolved
@archmoj archmoj merged commit 9361a88 into plotly:master Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@archmoj archmoj archmoj left review comments

Assignees
No one assigned
Labels
bug something broken community community contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

scatter3d markers are fully opaque when marker opacity: 0
2 participants
@dmyronuk @archmoj